Rename env to EC2_INSTANCE_TAG #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jongwooo
requested review from
ispeakc0de,
ksatchit and
uditgaurav
as code owners
jongwooo
force-pushed
the
rename-env-to-ec2-instance-tag
branch
from
0d0dbdc
to
a053f3e
Compare
ispeakc0de
approved these changes
Aug 9, 2024
|
Can you fix the pre-checks build? |
neelanjan00
approved these changes
Aug 9, 2024
Jonsy13
approved these changes
Aug 12, 2024
|
Hi @jongwooo |
|
@Jonsy13 Sure thing:) |
Signed-off-by: Jongwoo Han <[email protected]>
jongwooo
force-pushed
the
rename-env-to-ec2-instance-tag
branch
from
a053f3e
to
acaeac9
Compare
dusdjhyeon
pushed a commit
to dusdjhyeon/litmus-go
that referenced
this pull request
Aug 21, 2024
Signed-off-by: Jongwoo Han <[email protected]> Signed-off-by: dusdjhyeon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Related issue litmuschaos/litmus#4807 (comment)
This PR fixes an issue where the ec2-stop-by-tag experiment fails to target the intended EC2 instance.
The ec2-stop-by-tag experiment encounters a
TARGET_SELECTION_ERRORdue to an incorrect retrieval of theEC2_INSTANCE_TAGenvironment variable.By correctly renaming the environment variable from
INSTANCE_TAGtoEC2_INSTANCE_TAG, we can accurately target the intended EC2 instance.Special notes for your reviewer:
cc. @namkyu1999
Checklist:
breaking-changestagrequires-upgradetag