-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Litmus 3.0: Added enhancements in subscriber for Litmus 3.0 #4027
Conversation
Signed-off-by: Amit Kumar Das <[email protected]>
Signed-off-by: Amit Kumar Das <[email protected]>
Signed-off-by: Amit Kumar Das <[email protected]>
continue | ||
} | ||
if r.Payload.Errors != nil { | ||
logrus.Error("Error response from the server : ", string(message)) |
Check failure
Code scanning / CodeQL
Log entries created from user input High
user-provided value
|
||
// disable ssl verification if configured | ||
if strings.ToLower(infraData["SKIP_SSL_VERIFY"]) == "true" { | ||
http.DefaultTransport.(*http.Transport).TLSClientConfig = &tls.Config{InsecureSkipVerify: true} |
Check failure
Code scanning / CodeQL
Disabled TLS certificate check High
// disable ssl verification if configured | ||
if strings.ToLower(infraData["SKIP_SSL_VERIFY"]) == "true" { | ||
http.DefaultTransport.(*http.Transport).TLSClientConfig = &tls.Config{InsecureSkipVerify: true} | ||
websocket.DefaultDialer.TLSClientConfig = &tls.Config{InsecureSkipVerify: true} |
Check failure
Code scanning / CodeQL
Disabled TLS certificate check High
|
||
cfg, err := k8s.GetKubeConfig() | ||
if err != nil { | ||
logrus.WithError(err).Fatal("could not get config") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logrus.WithError(err).Fatal("could not get config") | |
logrus.WithError(err).Fatal("could not get kube config") |
|
||
cfg, err := k8s.GetKubeConfig() | ||
if err != nil { | ||
logrus.WithError(err).Fatal("could not get config") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logrus.WithError(err).Fatal("could not get config") | |
logrus.WithError(err).Fatal("could not get kubeconfig") |
Signed-off-by: Amit Kumar Das <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks Good 🚀 |
…tmuschaos#4027) * feat: Litmus 3.0: Added subscriber base setup Signed-off-by: Amit Kumar Das <[email protected]> * feat: Litmus 3.0: Added events for chaosengine and workflows Signed-off-by: Amit Kumar Das <[email protected]> * feat: Litmus 3.0: Added logs and minor changes Signed-off-by: Amit Kumar Das <[email protected]> * updated logs Signed-off-by: Amit Kumar Das <[email protected]> --------- Signed-off-by: Amit Kumar Das <[email protected]> Co-authored-by: Saranya Jena <[email protected]>
…tmuschaos#4027) * feat: Litmus 3.0: Added subscriber base setup Signed-off-by: Amit Kumar Das <[email protected]> * feat: Litmus 3.0: Added events for chaosengine and workflows Signed-off-by: Amit Kumar Das <[email protected]> * feat: Litmus 3.0: Added logs and minor changes Signed-off-by: Amit Kumar Das <[email protected]> * updated logs Signed-off-by: Amit Kumar Das <[email protected]> --------- Signed-off-by: Amit Kumar Das <[email protected]> Co-authored-by: Saranya Jena <[email protected]> Signed-off-by: SohamRatnaparkhi <[email protected]>
Proposed changes
Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: