Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation errors in choas_hub/handler tests #4052

Closed
SohamRatnaparkhi opened this issue Jul 3, 2023 · 4 comments
Closed

Compilation errors in choas_hub/handler tests #4052

SohamRatnaparkhi opened this issue Jul 3, 2023 · 4 comments

Comments

@SohamRatnaparkhi
Copy link
Contributor

SohamRatnaparkhi commented Jul 3, 2023

What happened:
The tests - TestGetChartsPath and TestGetChartsData fail due to compilation errors.

What you expected to happen:
The tests shouldn't have compilation errors

Where can this issue be corrected?

In choascenter/graphql/server/pkg/chaoshub/handler/handler_test.go, on lines 36, 292, and 303 - `GetChartsPath(_, _, _) is called which takes three arguments. But while calling this function, at all three instances, only 2 parameters are provided and the third boolean parameter is not provided.

How to reproduce it (as minimally and precisely as possible):
Run any of the above mentioned testcases.

@punithnayak
Copy link
Contributor

hey @SohamRatnaparkhi are you working on this

@SohamRatnaparkhi
Copy link
Contributor Author

hey @SohamRatnaparkhi are you working on this

No

@punithnayak
Copy link
Contributor

can I raise pr for it

@ksatchit
Copy link
Member

ksatchit commented Jan 2, 2024

Fixed by #4113

@ksatchit ksatchit closed this as completed Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants