Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated infra scope from 'infra' to 'cluster' #4093

Merged
merged 4 commits into from
Jul 19, 2023

Conversation

Saranya-jena
Copy link
Contributor

Proposed changes

  • updated infra scope from 'infra' to 'cluster'

Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

@Saranya-jena Saranya-jena self-assigned this Jul 19, 2023
Copy link
Member

@vanshBhatia-A4k9 vanshBhatia-A4k9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@@ -1075,9 +1075,9 @@ func (in *infraService) GetManifest(token string) ([]byte, int, error) {

if !reqinfra.IsRegistered {
var respData []byte
if reqinfra.InfraScope == "infra" {
if reqinfra.InfraScope == "cluster" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Store the value in a constant and reuse it in all places

@amityt amityt requested a review from gdsoumya July 19, 2023 09:03
@Jonsy13
Copy link
Contributor

Jonsy13 commented Jul 19, 2023

Merging for now. Constants have been added as per review! @gdsoumya

@Jonsy13 Jonsy13 merged commit da2ab7e into litmuschaos:master Jul 19, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants