-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add loader in all the confirm buttons of Modals under User Management #4449
Comments
Screencast.from.19-02-24.04.20.11.PM.IST.webmHi @Saranya-jena will this work. |
@SahilKr24 @hrishavjha Can you confirm? |
Seems good to me, just a minor detail, we can also have the confirm button to be disabled when the modal opens i.e. the form is empty or not touched. |
@SahilKr24 ok sure let me take a look once. |
This is how it is handled if we click on So should I disable the button at the start? or we should keep it as it is? |
This should also be fine 👍🏻 |
Signed-off-by: aryan <[email protected]>
What happened:
Currently upon selecting the confirm button, the API takes some time to get resolved however there is no loader for this state which makes it a bit confusing.
What you expected to happen:
Add loader in all the confirm buttons of Modals under User Management
Where can this issue be corrected? (optional)
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
The text was updated successfully, but these errors were encountered: