Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable nag notices #4

Open
deltafactory opened this issue Jul 31, 2018 · 2 comments
Open

Disable nag notices #4

deltafactory opened this issue Jul 31, 2018 · 2 comments

Comments

@deltafactory
Copy link

Suggestion: Wrap the require() calls in the main plugin file in the check for the DISABLE_NAG_NOTICES constant. This saves the file read time.
@deltafactory
Copy link
Author

I think it also saves some DB/cache hits...

@jessuppi
Copy link
Member

jessuppi commented Aug 1, 2018

We might do this at some point, but for now the goal is to ensure timestamps in the database remain accurate regardless of nag notices being visible or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@deltafactory @jessuppi