Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not localize Welcome-view #297

Closed
1 task done
juggernautjp opened this issue Mar 20, 2021 · 1 comment
Closed
1 task done

Can not localize Welcome-view #297

juggernautjp opened this issue Mar 20, 2021 · 1 comment

Comments

@juggernautjp
Copy link
Contributor

Prerequisites

Description

"Welcome" view is not localized.

Steps to Reproduce

  1. Click "Settings" in "File" menu
  2. Click "Packages" in "Settings" view
  3. Click "Enable" in "atom-i18n" package
  4. Click "Settings" of the "atom-i18n" package
  5. Set "Language" to "???(ja)" in the list
  6. Click "Welcome" in "Help" menu
  7. "Welcome" view is appeared

Expected behavior:
Some English words in "Welcome" view and sentences are localized.

Actual behavior:
"Welcome" view has some English words.

Reproduces how often:
Always

Versions

- Atom    : 1.55.0
- Electron: 6.1.12
- Chrome  : 76.0.3809.146
- Node    : 12.4.0

Additional Information

image

TODO

  • The issue #237 includes this one, but I have already found other issues in atom-i18n.
    So, I will issue each bug of atom-i18n, and fix them for a couple of weeks (or months).
  • atom-i18n package might be possible to improve performance.
@liuderchi
Copy link
Owner

@juggernautjp Thanks for your contribution! Your fix has been published in v0.25.1
https://atom.io/packages/atom-i18n

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants