Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for missing SPS/PPS at beginning of segment #165

Open
j0sh opened this issue Jan 10, 2020 · 1 comment
Open

Add unit test for missing SPS/PPS at beginning of segment #165

j0sh opened this issue Jan 10, 2020 · 1 comment

Comments

@j0sh
Copy link
Collaborator

j0sh commented Jan 10, 2020

If the force-idr option is omitted from the encoder AVOptions while using nvidia transcoding, there will be decode errors at the beginning of playback. However, disabling this option currently doesn't lead to any unit test failures. We really should check that SPS/PPS aways exists via unit tests as a way of preserving this behavior.

Ideally this option wouldn't be needed at all; ffmpeg itself should but smart enough to emit extradata for the first frame after a flush; that would mitigate the need for the force-idr option.

@yondonfu
Copy link
Member

For reference, forced-idr is currently set here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants