-
-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parse
: add new option to throw when parameterLimit
is reached
#515
Comments
Hey @ljharb 👋 I would like to work on this. |
@IamLizu no need to "claim" issues in open source :-) just make a PR for anything that has a "help wanted" label |
I think it'd be important to add it in the same PR, otherwise we'd need two options (to not be a breaking change) |
(sorry, copying from previous comment) Yes, we can implement a single option to handle throw for both cases with clear message of which one exceeded. But I was wondering if that could be a re-factor on this. |
If it's released with support for only one limit, then it can't ever support a second limit without a breaking change. |
Agreed 🤝 And thanks for the early review on the PR 🙏 |
Perhaps instead, add a new option that throws whenever any limit is reached, including
arrayLimit
.See expressjs/express#5878
The text was updated successfully, but these errors were encountered: