Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor dead assignment #363

Open
partimScurra opened this issue Dec 11, 2024 · 2 comments
Open

Minor dead assignment #363

partimScurra opened this issue Dec 11, 2024 · 2 comments

Comments

@partimScurra
Copy link

p_freeze is set zero after check, though it's not used later in this function:

lkrg/src/p_lkrg_main.c

Lines 589 to 593 in 54da909

if (p_freeze) {
// Thaw all non-kernel processes
P_SYM(p_thaw_processes)();
p_freeze = 0;
}

@solardiz
Copy link
Contributor

@partimScurra Please feel free to send us a PR fixing this. Thanks!

Were you getting a warning on this from a compiler or static analysis tool (and which)?

@partimScurra
Copy link
Author

Got it from clang static analyzer. Gonna look into some other markers and send a PR with all the fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants