From c6357cbf30954028352e2598384b8fbd8d5f587d Mon Sep 17 00:00:00 2001 From: Vivek Khandelwal Date: Thu, 25 Apr 2024 12:24:06 +0000 Subject: [PATCH] Address PR comments --- lib/Conversion/TorchOnnxToTorch/DefaultDomainQtoZ.cpp | 2 ++ projects/pt1/e2e_testing/xfail_sets.py | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/Conversion/TorchOnnxToTorch/DefaultDomainQtoZ.cpp b/lib/Conversion/TorchOnnxToTorch/DefaultDomainQtoZ.cpp index 6a4175c78985..b55eb6a33ea2 100644 --- a/lib/Conversion/TorchOnnxToTorch/DefaultDomainQtoZ.cpp +++ b/lib/Conversion/TorchOnnxToTorch/DefaultDomainQtoZ.cpp @@ -851,6 +851,8 @@ void mlir::torch::onnx_c::populateDefaultDomainQtoZ( Torch::ValueTensorType resultType; float alpha, gamma; Value operand; + // Refer https://onnx.ai/onnx/operators/onnx__Selu.html for the default + // alpha and gamma values. if (binder.tensorOperand(operand) || binder.f32FloatAttr(alpha, "alpha", 1.67326) || binder.f32FloatAttr(gamma, "gamma", 1.0507) || diff --git a/projects/pt1/e2e_testing/xfail_sets.py b/projects/pt1/e2e_testing/xfail_sets.py index 5384b2733e50..f34b5a5e3b2c 100644 --- a/projects/pt1/e2e_testing/xfail_sets.py +++ b/projects/pt1/e2e_testing/xfail_sets.py @@ -2156,8 +2156,8 @@ "ElementwiseLog2IntModule_basic", "FlipModuleStaticShape_basic", "FlipNegativeIndexModule_basic", - # "HardsigmoidModule_basic", - # "HardsigmoidRandomModule_basic", + "HardsigmoidModule_basic", + "HardsigmoidRandomModule_basic", "PixelShuffleModuleStaticRank4Float32_basic", "ReflectionPad1dModule2dInput_Right", "ReflectionPad1dModule2dInput_basic",