feat: Added value to suppress creation of ClusterRole and ClusterRole… #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Bindung. If the value is not set, cluster roles will be created as before
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
|
Hey @db3f ! Thanks for creating this PR, we are currently in the process of refactoring the helm values and this will be addressed as part of that refactoring with version v0.20.0, so I'll leave this open for now. |
|
Fixed in
Verified with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have users using vCluster who experience problems when trying to uses certain features implying the creation au a ClusterRole/ClusterRoleBinding, since those users don't habe enough rights to do this. Our solution is to provide them with a Service account that has all RBAC rights needed to run vCluster. However, the vCluster helm chart wants to create a ClusterRole, ClusterRoleBinding anyhow. Therefore I added a "flag" suppressClusterRoleCreation to values.yaml to prevent the ClusterRole/ClusterRoleBinding from being created. If this flag is not set or set to false, CLusterRole creation will happen as before.
What issue type does this pull request address?
What does this pull request do? Which issues does it resolve?
Gives the option to suppress ClusterRole cration.
Please provide a short message that should be published in the vcluster release notes
Added a flag to values.yaml to optionally prevent the Creation auf a ClusterRole