From 8df52bfc68348b731e0b30056f218096b3e19384 Mon Sep 17 00:00:00 2001 From: Daniel White Date: Wed, 17 Jul 2024 14:28:52 +0200 Subject: [PATCH] Fixes for typing errors --- dftimewolf/lib/collectors/gcp_logging.py | 4 ++-- dftimewolf/lib/validators/datetime_validator.py | 2 +- tests/lib/args_validator.py | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/dftimewolf/lib/collectors/gcp_logging.py b/dftimewolf/lib/collectors/gcp_logging.py index ad0e7dbc4..f976f776e 100644 --- a/dftimewolf/lib/collectors/gcp_logging.py +++ b/dftimewolf/lib/collectors/gcp_logging.py @@ -44,8 +44,8 @@ def __init__(self, self._project_name = '' self._backoff = False self._delay = 0 - self.start_time = None - self.end_time = None + self.start_time: Optional[datetime.datetime] = None + self.end_time: Optional[datetime.datetime] = None def OutputFile(self) -> Tuple[Any, str]: """Generate an output file name and path""" diff --git a/dftimewolf/lib/validators/datetime_validator.py b/dftimewolf/lib/validators/datetime_validator.py index 284cf877d..2c87e4316 100644 --- a/dftimewolf/lib/validators/datetime_validator.py +++ b/dftimewolf/lib/validators/datetime_validator.py @@ -33,7 +33,7 @@ def _EnsureTimezone( # If there's no timezone information, we assume it is UTC. if (parsed_datetime.tzinfo is None or parsed_datetime.tzinfo.utcoffset(parsed_datetime) is None): - parsed_datetime = parsed_datetime.replace(tzinfo=datetime.UTC) + parsed_datetime = parsed_datetime.replace(tzinfo=datetime.timezone.utc) return parsed_datetime def Validate(self, argument_value: Any, diff --git a/tests/lib/args_validator.py b/tests/lib/args_validator.py index 518e1ff98..0739075e2 100644 --- a/tests/lib/args_validator.py +++ b/tests/lib/args_validator.py @@ -13,7 +13,7 @@ class CommaSeparatedValidatorTest(unittest.TestCase): """Tests CommaSeparatedValidator.""" - def testInit(self): + def testInit(self) -> None: """Tests initialization. Really, CommaSeparatedValidator is an abstract class so should never be @@ -29,7 +29,7 @@ def testInit(self): mock_init.assert_called_once() # pylint: enable=unused-variable - def testValidate(self): + def testValidate(self) -> None: """Tests validation.""" args_validator.CommaSeparatedValidator.__abstractmethods__=set() @@ -63,7 +63,7 @@ def testValidate(self): self.assertEqual(mock_validatesingle.call_count, 1) self.assertEqual(val, 'one,two,three') - def testValidateFailure(self): + def testValidateFailure(self) -> None: """Tests validation failure.""" def FailingValidateSingle(argument_value, _): if argument_value == 'three':