Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External client requests do not verify hostname #124

Open
javierdlrm opened this issue Oct 23, 2020 · 0 comments
Open

External client requests do not verify hostname #124

javierdlrm opened this issue Oct 23, 2020 · 0 comments

Comments

@javierdlrm
Copy link
Contributor

self._verify = self._get_verify(self._host, trust_store_path)

When sending a request, the bool parameter 'verify' indicates if the hostname has to be verified. This value is calculated using 'get_verify' method in the base client.

In case of external clients, this value is always false since the host name is passed as parameter to 'get_verify' and it's always different to the string "true". Instead, this parameter might be 'hostname_verification'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant