Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to note that a size of -1 will return all the results from the query #84

Closed
ctindel opened this issue Nov 17, 2017 · 3 comments

Comments

@ctindel
Copy link

ctindel commented Nov 17, 2017

Or we should note that omitting the size parameter will return all results from the query.

One or the other, its just that our docs don't currently answer the question of what to do if you want the full result set.

@ycombinator
Copy link
Contributor

ycombinator commented Nov 17, 2017

This input makes a scroll request under the hood. Such a request will always return all the hits (except with size = 0) eventually. The size only pertains to how many hits should be returned in each scroll (aka batch).

@ctindel
Copy link
Author

ctindel commented Nov 18, 2017

Ah ok that makes sense, thanks.

@ctindel ctindel closed this as completed Nov 18, 2017
@ycombinator
Copy link
Contributor

Related: #85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants