use only table_prefix as table name in case no valid date pattern is used #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can someone test on the community test this? |
|
I can test the fix-table-name on my environment. Is this ready for everyone? |
|
We signed the CLA |
|
cla/check |
|
jenkins test this please |
|
@alepuccetti The CLA check is still failing. Sometimes this happens when the email address for the commit and the email address you used to sign the CLA are different. Please take a look and let me know. Thanks! We’re looking forward to checking out your contribution. |
…used Before this patch, in case date_pattern = "" than the table name would have been `<table_prefix><table_separator>` insteadd of just `<table_prefix>`. Example config: - table_prefix => 'my_table' - table_separator => '_' - date_pattern => "" result - table_name = 'my_table_' Now the table_name will be 'my_table'.
|
💚 CLA has been signed |
|
@karenzone I re-signed with my personal email address the contribution agreement and rebase the branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, in case date_pattern = "" than the table name would
have been
<table_prefix><table_separator>insteadd of just<table_prefix>.Example
config:
result
Now the table_name will be 'my_table'.
Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/
Fixes #43
NOTE: This changes the table generation and addressing so it might be a breaking change.