Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP 500 POSTs are retried when retry_non_idempotent flag is false #105

Open
danhermann opened this issue Jun 24, 2019 · 1 comment
Open

Comments

@danhermann
Copy link
Contributor

With the following test config:

input {
  generator {
    count => 10 # Emit all lines n times, 0 is unlimited
  }
}

output {
    http {
        url => "https://httpstat.us/500"
        http_method => "post"
        format => "json"
        #retry_non_idempotent => false
    }
}

When retryable_codes are left at their default value that includes 500, HTTP 500 responses to POSTs are retried even though retry_non_idempotent defaults to false.

@kares
Copy link
Contributor

kares commented Jan 8, 2020

for anyone following here, this is caused by retry_non_idempotent being a http client flag atm.
so a retry will be made by a client if creating the connection fails (e.g. with an io error or timeout).
retry_non_idempotent does not apply for the plugin's retry mechanism. while its confusing to read a conf such as above and see the behavior - changing these are going to end up in breaking changes ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants