-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intermittent test failures especially in test_search #58
Comments
On my second rebuild of #55 (2507e28) , it failed with $ nosetests --with-coverage tests
......F...
======================================================================
FAIL: test search result
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/travis/build/jayvdb/loklak_python_api/tests/test.py", line 108, in test_search
self.assertEqual(int(result['search_metadata']['count']), 18)
AssertionError: 14 != 18 After another 10 rebuilds, it failed again: $ nosetests --with-coverage tests
......F...
======================================================================
FAIL: test search result
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/travis/build/jayvdb/loklak_python_api/tests/test.py", line 108, in test_search
self.assertEqual(int(result['search_metadata']['count']), 18)
AssertionError: 10 != 18 Seems like something is wrong server side. |
A simple way to reduce the number of failures ( & pretend it doesnt exist) is to assert the results are less than 18 hits. |
A simpler way to do this is by having the API responses be |
Sorry, I would much rather be spending my time analyzing the bug and fixing it. |
Continuing from #57 :
@sudheesh001 , How did you arrive at the conclusion that it is returning a 503? That conclusion seems inconsistent with the API returning 24 results instead of 18 at https://travis-ci.org/loklak/loklak_python_api/jobs/159654156 . |
I think this was with in the previous push when the server might be acting up. https://travis-ci.org/loklak/loklak_python_api/jobs/159662252
And yes you're right it looks like it's returning 24, that seems like a server side problem since the server decides the result, the API only bring it to the developers, please open an issue on loklak/loklak_server for the same. |
Investigating the build failures on #57 , there are many intermittent errors, mostly in the
test_search
assertion added by #55.The #57 build status were:
test_search
test_search
test_search
andtest_peers
I have done some Travis builds of master (78456e7), with results:
test_search
test_search
The test_peers failure has only occurred once so far.
The logging is always correctly reporting:
The
test_search
failures on Python 3.5 is always in the number of results:https://travis-ci.org/loklak/loklak_python_api/jobs/159657573 is slightly different, with fewer returned results
And this one only has 10 results:
https://travis-ci.org/loklak/loklak_python_api/jobs/159662252
On Python 2.7 it varies more, with higher results and other problems.
https://travis-ci.org/jayvdb/loklak_python_api/jobs/159741504 :
https://travis-ci.org/loklak/loklak_python_api/jobs/159654156 :
The text was updated successfully, but these errors were encountered: