New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move loom go tests to go-loom #173

Open

gakonst opened this issue Nov 20, 2018 · 0 comments

Contributor

gakonst commented Nov 20, 2018 •

edited

Loading

- Move https://github.com/loomnetwork/plasma-cash/blob/master/loom_test/src/client/address_mapper_client.go to go-loom
- Move https://github.com/loomnetwork/plasma-cash/blob/master/loom_test/src/client/client.go and https://github.com/loomnetwork/plasma-cash/blob/master/loom_test/src/client/root_chain_service.go to go-loom (these are the analogous of the Entity.ts class from loom-js)
Helper utilities for tests should be in the same directory with them: 2c) https://github.com/loomnetwork/plasma-cash/blob/master/loom_test/src/client/token_contract.go, https://github.com/loomnetwork/plasma-cash/blob/master/loom_test/src/client/setup.go#L155-L210
The functionality from here https://github.com/loomnetwork/plasma-cash/blob/master/loom_test/src/client/setup.go#L39-L153 should be part of the Client class. The goal here is to mimic the User.createOfflineUser functionality from loom-js, where createOfflineUser is a static method of the class (https://github.com/loomnetwork/loom-js/blob/master/src/plasma-cash/user.ts)
E2E Tests under https://github.com/loomnetwork/plasma-cash/tree/master/loom_test/src/cmd should move to go-loom or loomchain (no preference, not sure which is best, probably loomchain)

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment