Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] fix: test ci #10634

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[DO NOT MERGE] fix: test ci #10634

wants to merge 1 commit into from

Conversation

dhmlau
Copy link
Member

@dhmlau dhmlau commented Aug 16, 2024

There's consistently a test failure for Node.js 20 on macOS in CI which I cannot reproduce it locally. Creating this PR to test.

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@dhmlau dhmlau requested a review from raymondfeng as a code owner August 16, 2024 19:12
@dhmlau dhmlau changed the title fix: test ci [DO NOT MERGE] fix: test ci Aug 16, 2024
@warisniz02 warisniz02 mentioned this pull request Sep 4, 2024
Merged
8 tasks
@dhmlau
Copy link
Member Author

dhmlau commented Sep 4, 2024

It might be related to actions/setup-node#873

@dhmlau
fix: test ci
22ed07b 
Signed-off-by: dhmlau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raymondfeng raymondfeng Awaiting requested review from raymondfeng raymondfeng is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dhmlau