Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make y_obs optional for marginal_plot() #178

Open
samathizer opened this issue Oct 1, 2024 · 1 comment · May be fixed by #179
Open

Make y_obs optional for marginal_plot() #178

samathizer opened this issue Oct 1, 2024 · 1 comment · May be fixed by #179
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@samathizer
Copy link

There are use cases where we would like to inspect a model but we have no observed data at hand. For example if the model itself is a ensemble of models, the observed values are not easily available and we would still like to see the total effect of one feature in the form of the partial dependence plot as well as the average prediction per feature.

Proposition
Allow y_obs to be None. In that case only plot average of predicted as well as the histogram of the feature.
@lorentzenchr
Copy link
Owner

This feature sound reasonable to me. It would mean allowing for

  • plot_marginal(y_obs=None, ..)
  • compute_marginal(y_obs=None, ..)

PR welcome. I would recommend to start with the latter.

@lorentzenchr lorentzenchr added enhancement New feature or request help wanted Extra attention is needed labels Oct 1, 2024
@samathizer samathizer linked a pull request Oct 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ENH allow y_obs and y_pred in plot_marginal to be None. samathizer/model-diagnostics
2 participants
@lorentzenchr @samathizer