notable plugin fails when org uses SAML

[jayvdb]

I would rather not give my metrics token SAML approval. Can an org be skipped somehow?

  metrics/compute/jayvdb/plugins > notable > completed (error)
  {
    name: 'notable',
    result: {
      error: {
        message: 'Unexpected error',
        instance: GraphqlResponseError: Request failed due to following response errors:
         - Resource protected by organization SAML enforcement. You must grant your Personal Access token access to this organization.
            at /metrics/node_modules/@octokit/graphql/dist-node/index.js:70:13
            at runMicrotasks (<anonymous>)
            at processTicksAndRejections (node:internal/process/task_queues:96:5)
            at async Object.default [as notable] (file:///metrics/source/plugins/notable/index.mjs:20:62)
            at async file:///metrics/source/plugins/core/index.mjs:67:30
            at async Promise.all (index 0)
            at async metrics (file:///metrics/source/app/metrics/index.mjs:81:22)
            at async retry.retries.retries (file:///metrics/source/app/action/index.mjs:407:40)
            at async retry (file:///metrics/source/app/action/index.mjs:57:22)
            at async file:///metrics/source/app/action/index.mjs:406:28 {
          request: {
            query: 'query NotableContributions {\n' +
              '  user(login: "jayvdb") {\n' +
              '    repositoriesContributedTo(after: "Y3Vyc29yOnYyOpICzgktIp4=" first: 5, contributionTypes: [COMMIT, ISSUE, PULL_REQUEST], includeUserRepositories: false, orderBy: { field: STARGAZERS, direction: DESC'... 482 more characters
          },

[jayvdb]

Maybe this fixes it jayvdb/jayvdb@13e2885

[jayvdb]

nope; that just results in the generated SVG to be "Unexpected error".

[jayvdb]

adding <org>/* to repositories_skipped also didnt work.

[lowlighter]

The repositories_skipped doesn't work in this case because it's querying repositories by batch

It needs some errors handling in this instead I think:

metrics/source/plugins/notable/index.mjs

Lines 18 to 28 in ba5d3c4

	do {
	console.debug(`metrics/compute/${login}/plugins > notable > retrieving contributed repositories after ${cursor}`)
	const {user: {repositoriesContributedTo: {edges}}} = await graphql(queries.notable.contributions({login, types: types.map(x => x.toLocaleUpperCase()).join(", "), after: cursor ? `after: "${cursor}"` : "", self, repositories: data.shared["repositories.batch"] || 100}))
	cursor = edges?.[edges?.length - 1]?.cursor
	edges
	.filter(({node}) => imports.filters.repo(node, skipped))
	.filter(({node}) => ({all: true, organization: node.isInOrganization, user: !node.isInOrganization}[from]))
	.filter(({node}) => imports.filters.github(filter, {name: node.nameWithOwner, user: node.owner.login, stars: node.stargazers.totalCount, watchers: node.watchers.totalCount, forks: node.forks.totalCount}))
	.map(({node}) => contributions.push({handle: node.nameWithOwner, stars: node.stargazers.totalCount, issues: node.issues.totalCount, pulls: node.pullRequests.totalCount, organization: node.isInOrganization, avatarUrl: node.owner.avatarUrl}))
	pushed = edges.length
	} while ((pushed) && (cursor))

Will be tracked in #1371 👍