Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding content via $renderer->doc does not seem to work #289

Open
saschaleib opened this issue Apr 18, 2023 · 2 comments
Open

Adding content via $renderer->doc does not seem to work #289

saschaleib opened this issue Apr 18, 2023 · 2 comments

Comments

@saschaleib
Copy link

I have managed to make my Ad-Hoc Tags plugin ODT-compatible for the most part, but in some cases I had to use workarounds because I can not get the example for directly outputting to the render document to work:

$renderer->doc .= 'My ODT xml code and content';

This line simply does nothing at all for me.

In that particular case, I am trying to write ODT tags directly to the document (for features that are not built-in in the ODT plugin). So using cdata instead is not really feasible either.

Any chance to get this fixed? :-)

@Klap-in
Copy link
Collaborator

Klap-in commented Apr 18, 2023

I haven’t looked into it, but how do other plugins solve/workaround this, gives that maybe already ideas?

@saschaleib
Copy link
Author

At least all plugins I could find seem to only use the prepared functions and of course cdata() to communicate with the ODT plugin.

I haven't looked through the release notes if there is any reason to modify this behaviour. I would understand if this is considered an "internal property" and accessing it directly should not be possible. But in this case it would be good to have an alternative, e.g. a new write() function that directly, well, writes raw data to the document...

Another approach (or an additional functionality) might be an accessor to the document property (which is protected now) so more advanced plugins could directly talk to it (like, there are a number of useful functions here that don't seem to be exposed via the Renderer).

But either way, I just want to write custom tags to the output :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants