-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Add CI action to check that German and English translation keys are consistent
#9370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-fein
changed the title
Sep 27, 2024
Development
: Add CI action to check that translation keys are defined in both German and EnglishDevelopment
: Add CI action to check that German and English translation keys are consistent
b-fein
force-pushed
the
chore/development/check-translation-keys
branch
2 times, most recently
from
September 27, 2024 08:28
a4d80b1
to
bcc1759
Compare
b-fein
force-pushed
the
chore/development/check-translation-keys
branch
from
September 27, 2024 08:39
bcc1759
to
62db059
Compare
Great additional check, thank you 👍 |
raffifasaro
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM
Tested locally. The flattened keys in the output are always prepended with an additional dot:
|
The additional dot at the start is intentional since it represents a JSON pointer that way that can be directly used with |
krusche
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
CI script
Motivation and Context
As noted in #9369, there are discrepancies between the translation keys in German and English. We want to avoid this.
Description
This PR adds a helper script that runs in a CI action and checks that the translation keys defined in German and English are consistent. In detail it checks that
de/
anden/
directories contain files with the same names,The script accepts either two directories to compare the full directory content, or two files to compare the content of two files.
Steps for Testing
You can run the script locally. It should report the missing files as noticed in #9369 and find set of translation keys that only exist in German/English.
The CI action itself will maybe not run on this branch since configuration files are taken from the default branch (?), and we do not yet make changes to the translation files here.
Review Progress
Code Review
Manual Tests
Test Coverage
n/a
@coderabbitai ignore