Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unite PushNotificationSettingsScreen and NotificationSettingsUi #273

Open
FelberMartin opened this issue Jan 6, 2025 · 1 comment · May be fixed by #287
Open

Unite PushNotificationSettingsScreen and NotificationSettingsUi #273

FelberMartin opened this issue Jan 6, 2025 · 1 comment · May be fixed by #287
Assignees
Labels
chore House keeping; non-functional, non-visual changes

Comments

@FelberMartin
Copy link
Collaborator

Problem

There are currently two very similar composable functions PushNotificationSettingsScreen and NotificationSettingsUi, both for displaying the PushNotificationSettingsUi with a FAB button and triggering a save when the button is clicked. The first one is used for the settings screen (accessible by clicking on the settings icon on the top right), the latter appears when logging in the first time on a new server.

Suggested next steps

These two files can be merged and common logic should be extracted.

@FelberMartin FelberMartin added the chore House keeping; non-functional, non-visual changes label Jan 6, 2025
@julian-wls julian-wls self-assigned this Jan 7, 2025
@julian-wls
Copy link
Contributor

I think we can combine this issue and the missing save-dialog mentioned in #183 in one PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore House keeping; non-functional, non-visual changes
Projects
None yet
2 participants