Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Your plans for this library? #11

Open
SebastianStehle opened this issue Sep 17, 2023 · 2 comments
Open

Your plans for this library? #11

SebastianStehle opened this issue Sep 17, 2023 · 2 comments

Comments

@SebastianStehle
Copy link

SebastianStehle commented Sep 17, 2023

Hi,

I started to dig into yjs last week and was thinking about an integration to redux. Your library inspired me but didn't fulfill my requirements:

  1. Make only the necessary changes.
  2. Keep redux instances intact if nothing has been changed.
  3. Support custom domain object classes.
  4. Support custom collections.
  5. Support custom value types (e.g. Color, Vector and so on).
  6. Detect inserts and removals in arrays.

So I built my own test: https://github.com/SebastianStehle/yjs-test

it is not a library yet, but already fulfills the requirements and has a decent amount of tests to ensure it works as indented. But I think there is no need to have 2 bindings. So I would like to be interested to know about your plans:

  1. Do you still work with yjs?
  2. Are you interested to work together?

I would like to have an official redux / react binding. So the goal should be to integrate the project into the yjs organization if @dmonad agrees with that. At the moment I struggle to find a good starter for typescript libs, this is my main blocker at the moment.

EDIT: I converted it to a library: https://github.com/sebastianstehle/yjs-redux

@lscheibel
Copy link
Owner

Hey, thanks for the interest! Your solution looks really impressive and seems to be a plain superior version of mine here haha.
I don't really work with yjs anymore so as you can see I haven't really touched this library again. As far as I can tell, adding your library to any existing Redux instance should just work, correct? If that's the case and if that is something that you will want to continue, then I think this project here has been superseded. I would likely keep the repo as it is for a while but add a big link to yours. If nothing happens for a while I might archive this repo. What do you think?

@SebastianStehle
Copy link
Author

Sure, sounds good. I am talking with the guys from y-sweet (https://y-sweet.dev/js/react) to integrate it there, but I still need to fix some bugs. Once it is done I can update you and if you want you can achieve the repo and add a link. Would be great for the community :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants