Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segmentation Fault in optimized cases #1

Open
devildonkey1392 opened this issue Jun 14, 2021 · 4 comments
Open

Segmentation Fault in optimized cases #1

devildonkey1392 opened this issue Jun 14, 2021 · 4 comments

Comments

@devildonkey1392
Copy link

Hi,

The commit 510579a of mockturtle seems to be deleted.

Therefore, I checkout the mockturtle to a1f0f90 which is also from pull request #231.

However, when I try to run the experiments, it encounters segmentation fault while doing resubstitution in some cases.

For those can't further optimize, the program can finish successfully.

How to fix this problem ?

Thanks a lot!

@hriener
Copy link
Member

hriener commented Jun 14, 2021

Could you be more specific?

It takes quite some time to run the experiments on my computer.
Which one segfaults?

@devildonkey1392
Copy link
Author

devildonkey1392 commented Jun 14, 2021

Hi,

Thanks for your response.

I download the source code of version(510579a) and build the code again.

It can work right now!

As for version(a1f0f90), I try the cavlc and div. Both of them get segmentation fault while doing resubstitution.

@hriener
Copy link
Member

hriener commented Jun 14, 2021

I download the source code of version(510579a) and build the code again.

It can work right now!

Means that the issue has been resolved?

@hriener
Copy link
Member

hriener commented Jun 14, 2021

As a side note, I can reproduce the segfault with benchmark cavlc_untilsat on commit a1f0f90.

You could try this code on the branch master. I recently fixed some pointer issues in the event API. This could be the problem that you are hitting in the old implementation. Note that on the master branch, cut_rewriting has to be replaced with cut_rewriting_with_compatibility_graph. Also, note that a couple of changes have been made to the resubstitution algorithm. I'm not sure if there is any impact on these experiments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants