Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-40822: Update Prompt Processing docs to remove references to the IDF #93

Merged
merged 5 commits into from
Nov 9, 2023

Conversation

kfindeisen
Copy link
Member

@kfindeisen kfindeisen commented Nov 7, 2023

This PR removes documentation and code that was valid only with the old Google Cloud environment. It also stops the vestigial Google Artifact Registry upload, which we haven't been using for either USDF deployments or prompt-proto-service builds.

This PR should not be merged before November 10 or before a w_2023_45 base is available, because it will overwrite the current w_2023_44 container (no behavior changes will occur, but it causes bookkeeping problems for the biweekly AuxTel run).

The Prompt Processing code in `main` has not supported Google Cloud in
over a year, and the old services running on GCP have now been
shut down.
The old instructions referred to ``gcloud builds``, which we stopped
using even while we were still running on Google Cloud.
These comments have been updated for USDF/S3, where appropriate.
Neither the .gcloudignore file nor the Google logger are useful outside
the Google Cloud environment.
@kfindeisen kfindeisen marked this pull request as ready for review November 7, 2023 17:58
Copy link
Collaborator

@hsinfang hsinfang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kfindeisen
Copy link
Member Author

Merging one day early; I'll make sure any containers are built using the latest daily rather than weekly 44.

@kfindeisen kfindeisen merged commit 2d9be25 into main Nov 9, 2023
6 checks passed
@kfindeisen kfindeisen deleted the tickets/DM-40822 branch November 9, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants