Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible issue with password quality settings in SSP 1.6 #928

Open
unquietwiki opened this issue Jun 30, 2024 · 4 comments
Open

Possible issue with password quality settings in SSP 1.6 #928

unquietwiki opened this issue Jun 30, 2024 · 4 comments
Labels
bug feedback required Waiting for a feedback
Milestone

Comments

@unquietwiki
Copy link

unquietwiki commented Jun 30, 2024

Hey all. Per mention in #918, whenever I have the config.inc.local.php file set to use any password quality values (length or special chars), it declines the new password with a "Insufficient quality" error. Digging into the code, I believe the error is tied to behavior in lib/functions.inc.php or htdocs/js/ppolicy.js. I had SonarLint installed, and it found a number of warnings with the code in regards to boolean condition matching; test editing to resolve most of those issues did not change the situation. $pwd_check_entropy is set to false in the config file, so ZXCVBN shouldn't be a factor here.

SSP 1.6 using Debian 12 package install

@coudot coudot added the bug label Jul 1, 2024
@coudot coudot added this to the 1.6.1 milestone Jul 1, 2024
@coudot
Copy link
Member

coudot commented Jul 2, 2024

Please set $debug to true and provide the logs.

@unquietwiki
Copy link
Author

Okay... so, if I set $pwd_min_length = 10, I get the "insufficient quality" error in the browser, but no entries in audit.log from those attempts. If I set it to 0, then I'll get an "ldaperror" from my #918 problem. I tried the F12 developer console in my browser, but wasn't seeing any errors being thrown out.

Regardless of the setting, I am getting a Smarty error in the error.log of Nginx whenever I do try to do a password reset. I don't think its the cause of the quality check error, but might be useful as a data point.

PHP message: PHP Deprecated: Creation of dynamic property Smarty_Internal_Template::$compiled is deprecated in /usr/share/php/smarty3/sysplugins/smarty_internal_template.php on line 719;

@coudot
Copy link
Member

coudot commented Jul 3, 2024

Check the error log (depending on your installation, in Apache log or PHP FPM log)

Audit log is only here to trace events

@unquietwiki
Copy link
Author

There is nothing in the PHP FPM or Nginx logs that correlates to my attempts at a reset with the check enabled.

@coudot coudot modified the milestones: 1.6.1, 1.7.0 Jul 8, 2024
@davidcoutadeur davidcoutadeur added the feedback required Waiting for a feedback label Jul 19, 2024
@coudot coudot modified the milestones: 1.7.0, Backlog Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feedback required Waiting for a feedback
Projects
None yet
Development

No branches or pull requests

3 participants