Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple tx versions #29

Open
jasny opened this issue Jan 17, 2022 · 0 comments
Open

Support multiple tx versions #29

jasny opened this issue Jan 17, 2022 · 0 comments
Assignees

Comments

@jasny
Copy link
Member

jasny commented Jan 17, 2022

For most transaction types, there are multiple versions. The version determines the binary structure. Some fields may not be available in older versions. Also, v3 is required to support sponsored transactions.

Please add version support for all transaction types. The default version should be 3. It should be possible to modify the version property. When calling toBinary() check the tx version and switch to the correct implementation. Either use multiple methods within the tx class (like python does) or use Pack classes for each tx type and version combination. If an unsupported version is used, throw an exception.

The version should be correctly set when creating the tx object from json.

@KaloyanTanev KaloyanTanev self-assigned this Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants