"Settings in the pause menu" to-do list

[grorp]

Follow-up to #6722 (comment) and #15614

• Add missing setting callbacks

  • Rendering pipeline / RenderingCore (could probably adapt approach in Add Settings to in-game menu, and rewrite pause menu in Lua #14785, grep for reloadGraphics)
  • Dynamic shadows (could probably adapt approach in Add Settings to in-game menu, and rewrite pause menu in Lua #14785)
  • "Effects" implemented in node, object shaders (probably complicated and needs shader recompilation)
  • Hud (scaling settings already done in Limit crosshair scaling to integer multiples to avoid distortion #14501 and Add missing setting callbacks for display_density_factor #15273)
  • TouchControls -> Add setting callbacks for Camera and TouchControls #15700
  • Camera (including FOV) -> Add setting callbacks for Camera and TouchControls #15700
  • Probably many more

• Deal with client-side vs server-side vs both sides settings correctly

  • Mark all settings as client-side, server-side or both sides in settingtypes.txt (need to go through all settings?)
  • Only show server-side settings in the pause menu if on local server / in singleplayer

• Deal with settings that cannot be changed in-game and that we don't want/plan to make changeable in-game

  • (Most settings should eventually be made changeable in-game. An example of something that doesn't make sense could be mapgen settings.)
  • Mark relevant settings in settingtypes.txt as "requires rejoin" or "requires restart"
  • Gray out settings that cannot be changed in the pause menu (hiding them entirely would be confusing)

[Desour]

Gray out settings that cannot be changed in the pause menu (hiding them entirely would be confusing)

Or just put a notice there. It's useful if you can change it in-game and then just rejoin, imo.

Btw., there's also settings where you have to restart the game entirely, not just rejoin. video_driver for example.