Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous range for discretize area #91

Open
sbriseid opened this issue Jul 8, 2024 · 2 comments
Open

Continuous range for discretize area #91

sbriseid opened this issue Jul 8, 2024 · 2 comments

Comments

@sbriseid
Copy link

sbriseid commented Jul 8, 2024

Hi @lucidrains and @MarcusLoppe!

It seems that the area discretizer has an inefficient bin usage for the triangle mesh, using only the first half:
self.discretize_area = partial(discretize, num_discrete = num_discrete_area, continuous_range = (0., (hi - lo) ** 2))

This is correct for quad meshes, but for triangles there should be a 0.5 factor for the upper limit:
continuous_range = (0., (hi - lo) ** 2) if quads else (0., 0.5 * (hi - lo) ** 2

@lucidrains
Copy link
Owner

lucidrains commented Jul 8, 2024

@sbriseid I don't think that extra scale matters for the network, but yes, technically incorrect area for triangle

@sbriseid
Copy link
Author

sbriseid commented Jul 8, 2024

I agree, the scaling should not matter. I was thinking that increasing from the available 64 to the full 128 bins, which allows for improved separation between triangles of almost equal area, could be of some value. But it is far from the level of the fix that addressed the issue where all triangles had area 0.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants