You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems that the area discretizer has an inefficient bin usage for the triangle mesh, using only the first half: self.discretize_area = partial(discretize, num_discrete = num_discrete_area, continuous_range = (0., (hi - lo) ** 2))
This is correct for quad meshes, but for triangles there should be a 0.5 factor for the upper limit: continuous_range = (0., (hi - lo) ** 2) if quads else (0., 0.5 * (hi - lo) ** 2
The text was updated successfully, but these errors were encountered:
I agree, the scaling should not matter. I was thinking that increasing from the available 64 to the full 128 bins, which allows for improved separation between triangles of almost equal area, could be of some value. But it is far from the level of the fix that addressed the issue where all triangles had area 0.5.
Hi @lucidrains and @MarcusLoppe!
It seems that the area discretizer has an inefficient bin usage for the triangle mesh, using only the first half:
self.discretize_area = partial(discretize, num_discrete = num_discrete_area, continuous_range = (0., (hi - lo) ** 2))
This is correct for quad meshes, but for triangles there should be a 0.5 factor for the upper limit:
continuous_range = (0., (hi - lo) ** 2) if quads else (0., 0.5 * (hi - lo) ** 2
The text was updated successfully, but these errors were encountered: