Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarkus integration #429

Closed
lw-mcno opened this issue Mar 3, 2021 · 6 comments
Closed

Quarkus integration #429

lw-mcno opened this issue Mar 3, 2021 · 6 comments

Comments

@lw-mcno
Copy link

lw-mcno commented Mar 3, 2021

First of all, thanks for providing and maintaining this useful library.

Are there any plans of supporting a Quarkus integration?

@lukas-krecan
Copy link
Owner

Hi, thanks for feedback. There are no such plans since I am otherwise engaged. If you need it, you can implement it yourself. With Quarkus interceptors it should be quite easy. You can use the Micronaut implementation as an inspiration. It's just few classes. If you do that, please send PR, I will be happy to merge it.

@lukas-krecan
Copy link
Owner

lukas-krecan added a commit that referenced this issue Nov 15, 2022
lukas-krecan added a commit that referenced this issue Nov 15, 2022
@lukas-krecan
Copy link
Owner

Rundimentary support will be part of 5.0.0 release

@dcdh
Copy link

dcdh commented Mar 6, 2024

Hello all, I am doing some work on it.
You can have a look to this PR: quarkiverse/quarkus-shedlock#3

Regards,

Damien

@lukas-krecan
Copy link
Owner

@dcdh There already is CDI integration tested with Quarkus. Is there anything missing that would justify creating a new project to do the same?

@dcdh
Copy link

dcdh commented Mar 7, 2024

I guess yes.
I have added build time code to avoid declaring beans by ourself.
A developer can just add an annotation to make it works without producing expected LockProvider. It is done out of the box.
I've keep the same module hierarchy (providers and next specifique ones)

Regarding Jdbc, a developer can specify the datasource to use and the extension will validate it at build time (check that specified datasource existe).
Moreover, regarding table création I could not rely on ShedLock jdbc template dependency because I do not want to add Spring jdbc dependency inside a Quarkus application. So I have redevelop an initialiser bound one each datasource used.

The developer can use multiple providers if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants