Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor codes main.ts and idls.ts. #101

Open
romandev opened this issue Oct 3, 2017 · 1 comment
Open

Refactor codes main.ts and idls.ts. #101

romandev opened this issue Oct 3, 2017 · 1 comment
Assignees
@romandev

Comments

@romandev
Copy link
Member

romandev commented Oct 3, 2017

The complexity of the two files has increased, on the other hand, readability has decreased. We should split into smaller files and clear their purpose.
@romandev romandev self-assigned this Oct 3, 2017
@romandev
Copy link
Member Author

romandev commented Oct 3, 2017

I'll start this work.

romandev added a commit that referenced this issue Oct 3, 2017
@romandev
Introduce reader concept and implement simple_reader.ts.
7669a91 
The reader is IDL files reader. The module is responsible for reading
the idl files at the proper timing. But for now, making implementation
easier, just implement simple_reader.ts. The simple implementation just
reads all IDL files without pipelining and then unifies them into one
simple data.

ISSUE=#101
@romandev romandev mentioned this issue Oct 3, 2017
Merged
romandev added a commit that referenced this issue Oct 3, 2017
@romandev
Introduce reader concept and implement simple_reader.ts. (#103)
a80fc11 
The reader is IDL files reader. The module is responsible for reading
the idl files at the proper timing. But for now, making implementation
easier, just implement simple_reader.ts. The simple implementation just
reads all IDL files without pipelining and then unifies them into one
simple data.

ISSUE=#101
romandev added a commit that referenced this issue Oct 5, 2017
@romandev
Refactoring: Split idls.ts into smaller files.
fecf2da 
Along with increasing external contribution, the complexity of the file
has increased as well. On the other hand, readability has decreased.
So, we should split the file into smaller files and clear their purpose.

The main goal of this change is spliting the idls.ts file into serveral
files and removing it.

ISSUE=#101
@romandev romandev mentioned this issue Oct 5, 2017
Merged
romandev added a commit that referenced this issue Oct 6, 2017
@romandev
Refactoring: Split idls.ts into smaller files. (#109)
eb54d9b 
Along with increasing external contribution, the complexity of the file
has increased as well. On the other hand, readability has decreased.
So, we should split the file into smaller files and clear their purpose.

The main goal of this change is spliting the idls.ts file into serveral
files and removing it.

ISSUE=#101
romandev added a commit that referenced this issue Oct 7, 2017
@romandev
Add original IDL information (filename and location) to IDL definition
6677111 
This is removing hard-coded value(examples/) in generateInterface() in
generator/main.ts. This is also resolving a problem that the CWD path is
differnt in Windows during generating.

ISSUE=#101
romandev added a commit that referenced this issue Oct 7, 2017
@romandev
Add original IDL information (filename and location) to IDL definition
8dd731e 
This is removing hard-coded value(examples/) in generateInterface() in
generator/main.ts. This is also resolving a problem that the CWD path is
differnt in Windows during generating.

ISSUE=#101
@romandev romandev mentioned this issue Oct 7, 2017
Merged
romandev added a commit that referenced this issue Oct 7, 2017
@romandev
Add original IDL information (filename and location) to IDL definition (
de903fe 
#112)

This is removing hard-coded value(examples/) in generateInterface() in
generator/main.ts. This is also resolving a problem that the CWD path is
differnt in Windows during generating.

ISSUE=#101
romandev added a commit that referenced this issue Oct 18, 2017
@romandev
Introduce reader concept and implement simple_reader.ts. (#103)
6936246 
The reader is IDL files reader. The module is responsible for reading
the idl files at the proper timing. But for now, making implementation
easier, just implement simple_reader.ts. The simple implementation just
reads all IDL files without pipelining and then unifies them into one
simple data.

ISSUE=#101
romandev added a commit that referenced this issue Oct 18, 2017
@romandev
Refactoring: Split idls.ts into smaller files. (#109)
60128cb 
Along with increasing external contribution, the complexity of the file
has increased as well. On the other hand, readability has decreased.
So, we should split the file into smaller files and clear their purpose.

The main goal of this change is spliting the idls.ts file into serveral
files and removing it.

ISSUE=#101
romandev added a commit that referenced this issue Oct 18, 2017
@romandev
Add original IDL information (filename and location) to IDL definition (
301d2d3 
#112)

This is removing hard-coded value(examples/) in generateInterface() in
generator/main.ts. This is also resolving a problem that the CWD path is
differnt in Windows during generating.

ISSUE=#101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romandev romandev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@romandev