Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning in Examples #197

Open
3 of 8 tasks
yjaeseok opened this issue Nov 20, 2017 · 2 comments
Open
3 of 8 tasks

Fix warning in Examples #197

yjaeseok opened this issue Nov 20, 2017 · 2 comments

Comments

@yjaeseok
Copy link
Contributor

I'm submitting a ...

  • bug report
  • feature request
  • support request

General infomration

Prerequisites

  • Are you running the latest version?

Description

We have some build warnings.

C:\projects\bacardi\core/js_type_traits.h(54): warning C4244: 'argument': conversion from 'int64_t' to 'double', possible loss of data (compiling source file ..\build\Release\obj\global_intermediate\examples\ternary_calculator_bridge.cc) [C:\projects\bacardi\build\bacardi.vcxproj]
C:\projects\bacardi\core/js_type_traits.h(55): warning C4244: 'argument': conversion from 'uint64_t' to 'double', possible loss of data (compiling source file ..\build\Release\obj\global_intermediate\examples\ternary_calculator_bridge.cc) [C:\projects\bacardi\build\bacardi.vcxproj]
C:\projects\bacardi\core/js_type_traits.h(54): warning C4244: 'argument': conversion from 'int64_t' to 'double', possible loss of data (compiling source file ..\build\Release\obj\global_intermediate\examples\calculator_bridge.cc) [C:\projects\bacardi\build\bacardi.vcxproj]
C:\projects\bacardi\core/js_type_traits.h(55): warning C4244: 'argument': conversion from 'uint64_t' to 'double', possible loss of data (compiling source file ..\build\Release\obj\global_intermediate\examples\calculator_bridge.cc) [C:\projects\bacardi\build\bacardi.vcxproj]
..\build\Release\obj\global_intermediate\examples\calculator_bridge.cc(301): warning C4244: 'argument': conversion from 'double' to 'int64_t', possible loss of data [C:\projects\bacardi\build\bacardi.vcxproj]
electron_native_bridge.cc
test_interface_bridge.cc
C:\projects\bacardi\core/js_type_traits.h(54): warning C4244: 'argument': conversion from 'int64_t' to 'double', possible loss of data (compiling source file ..\build\Release\obj\global_intermediate\examples\electron\native\electron_native_bridge.cc) [C:\projects\bacardi\build\bacardi.vcxproj]
C:\projects\bacardi\core/js_type_traits.h(55): warning C4244: 'argument': conversion from 'uint64_t' to 'double', possible loss of data (compiling source file ..\build\Release\obj\global_intermediate\examples\electron\native\electron_native_bridge.cc) [C:\projects\bacardi\build\bacardi.vcxproj]
bacardi.cc
C:\projects\bacardi\core/js_type_traits.h(54): warning C4244: 'argument': conversion from 'int64_t' to 'double', possible loss of data (compiling source file ..\build\Release\obj\global_intermediate\test\test_interface_bridge.cc) [C:\projects\bacardi\build\bacardi.vcxproj]
C:\projects\bacardi\core/js_type_traits.h(55): warning C4244: 'argument': conversion from 'uint64_t' to 'double', possible loss of data (compiling source file ..\build\Release\obj\global_intermediate\test\test_interface_bridge.cc)

Context (Environment)

Operating System

  • Linux (x86/x64)
  • OSX (x86/x64)
  • Windows (x86/x64)
  • Linux (ARM)

Additional Information on the environment

I see this warnings, in AppVeyor.
Please refer to below link : https://ci.appveyor.com/project/romandev/bacardi/build/1.0.356/job/ynvl38uaec1r0r30

@daehyunjimmy
Copy link
Contributor

I will handle this issue. :)

@daehyunjimmy
Copy link
Contributor

daehyunjimmy commented Nov 20, 2017

now, static Number New (napi_env env, double value)'s parameter type is double.
so, conversion from 'uint64_t' to 'double', could be possible loss of data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants