Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lv_anim_set_duration() defined twice #7498

Open
tdjastrzebski opened this issue Dec 22, 2024 · 2 comments · May be fixed by #7500
Open

lv_anim_set_duration() defined twice #7498

tdjastrzebski opened this issue Dec 22, 2024 · 2 comments · May be fixed by #7500

Comments

@tdjastrzebski
Copy link
Contributor

tdjastrzebski commented Dec 22, 2024 •
edited
Loading

LVGL version

9.3.0.dev

Platform

GCC 13 on Windows

What happened?

The current version does not build, function lv_anim_set_duration() is indirectly defined twice:

  1. lv_api_map_v9_1.h defines this alias
    97: #define lv_anim_set_time lv_anim_set_duration
  2. in lv_anim.c
    359: void lv_anim_set_duration(lv_anim_t * a, uint32_t duration)
    364: void lv_anim_set_time(lv_anim_t * a, uint32_t duration)
    Since lv_anim_set_time = lv_anim_set_duration the above line redefines lv_anim_set_duration().
    I suggest removing duplicate lv_anim_set_time() definition from lv_anim.c and keeping alias only.

image

image

image

How to reproduce?

No response
kisvegabor added a commit to kisvegabor/lvgl_fork that referenced this issue Dec 22, 2024
@kisvegabor
fix(anim): remove the redefinition of lv_anim_set_time
2fddac6 
fixes lvgl#7498
@kisvegabor kisvegabor linked a pull request Dec 22, 2024 that will close this issue
Open
@kisvegabor
Copy link
Member

Ah, how wasn't it caught by our CI? Anyway, I've just opened PR to fix it: #7500

@tdjastrzebski
Copy link
Contributor Author

I guess, it is good to try different build methods :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(anim): remove the redefinition of lv_anim_set_time kisvegabor/lvgl_fork
2 participants
@tdjastrzebski @kisvegabor