Fix compatibility with liblxc 4.0.4 and newer #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It depended on a function from liblxc, which is no longer exported due to lxc/lxc@63c2a0b Signed-off-by: Jakub Skokan <[email protected]>
…blxc Signed-off-by: Jakub Skokan <[email protected]>
aither64
force-pushed
the
liblxc-compat
branch
from
d1381dd to
2d171f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruby-lxcis broken with LXC 4.0.4 and newer, as two used external functions were removed from liblxc (see #45). This PR makesruby-lxcwork again with the following changes:lxc_config_parse_arch()from liblxc was used inLXC.arch_to_personality(). I don't know what can this method be used for, I've just removed it.lxc_wait_for_pid_status()does nothing special, I've added it's implementation intoruby-lxc.Fixes #45