Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please document that words are not accounted for #22

Open
dancor opened this issue Nov 2, 2018 · 0 comments
Open

Please document that words are not accounted for #22

dancor opened this issue Nov 2, 2018 · 0 comments

Comments

@dancor
Copy link

dancor commented Nov 2, 2018

Thank you for the work on this library. A big and easy improvement to its usefulness is to prominently document that it currently performs a character-level translation, which is incorrect for many common words and sentences.

>>> import pinyin
>>> pinyin.get('了解', format='numerical')
'le5jie3'

The output should be

'liao3jie3'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant