-
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider renaming fail_map
to error_map
#1446
Labels
breaking-change
bug
Something isn't working
good first issue
Good for newcomers
help wanted
Extra attention is needed
Comments
Related discussion, which could be tackled at the same time: #1013 |
I totally agree with that change 👍 As for #1013 this was actually already implemented in 250f7a8. Although, I think that the The current JSON output looks like: "success_map": {
"http://www.example.com/": [
{
"url": "https://www.iana.org/domains/example",
"status": {
"text": "OK (200 OK)",
"code": 200
}
}
]
},
|
Yup, sounds like a good idea! |
mre
added
bug
Something isn't working
good first issue
Good for newcomers
help wanted
Extra attention is needed
breaking-change
and removed
waiting-for-feedback
labels
Sep 27, 2024
mre
added a commit
that referenced
this issue
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking-change
bug
Something isn't working
good first issue
Good for newcomers
help wanted
Extra attention is needed
We no longer use the term
failure
in our system; we now refer to it aserror
. Therefore, it makes sense to renamefail_map
toerror_map
for consistency. Similar to #1443, this will introduce a breaking change, but since we haven't reached a stable version yet, I want to address these naming inconsistencies beforehand.The text was updated successfully, but these errors were encountered: