Add support for relative links #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mre
force-pushed
the
relative-links-v2
branch
from
91ee339
to
cbc615b
Compare
Closed
mre
force-pushed
the
relative-links-v2
branch
from
7a9347f
to
f64c8ae
Compare
mre
force-pushed
the
relative-links-v2
branch
2 times, most recently
from
be20046
to
9336a8d
Compare
This should work now, but it's hacked together like crazy and needs a lot of refactoring before we can merge this. Just pushing this upstream so that I don't forget about it.
mre
force-pushed
the
relative-links-v2
branch
from
9336a8d
to
384b15f
Compare
This was referenced Oct 26, 2024
Closed
Merged
mre
added a commit
that referenced
this pull request
Oct 27, 2024
This commit introduces several improvements to the file checking process and URI handling: - Extract file checking logic into separate `Checker` structs (`FileChecker`, `WebsiteChecker`, `MailChecker`) - Improve handling of relative and absolute file paths - Enhance URI parsing and creation from file paths - Refactor `create_request` function for better clarity and error handling These changes provide better support for resolving relative links, handling different base URLs, and working with file paths. Fixes #1296 and #1480
mre
added a commit
that referenced
this pull request
Oct 27, 2024
This commit introduces several improvements to the file checking process and URI handling: - Extract file checking logic into separate `Checker` structs (`FileChecker`, `WebsiteChecker`, `MailChecker`) - Improve handling of relative and absolute file paths - Enhance URI parsing and creation from file paths - Refactor `create_request` function for better clarity and error handling These changes provide better support for resolving relative links, handling different base URLs, and working with file paths. Fixes #1296 and #1480
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor file checking and improve URI handling
This commit introduces several improvements to the file checking process and URI handling:
FileCheckerstructcreate_requestfunction for better clarity and error handlingThese changes provide better support for resolving relative links, handling different base URLs, and working with file paths.
Fixes #1296 and #1480