From 73996e9b328e57a73f0a477f335fd6b10bc69788 Mon Sep 17 00:00:00 2001 From: Alex Chantavy Date: Mon, 22 Jul 2024 00:11:55 -0700 Subject: [PATCH] Minor edits to pull request template (#1337) ### Summary > Describe your changes. Small updates to PR template --- .github/pull_request_template.md | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 8ea718de85..7eba2bc2d6 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -9,17 +9,15 @@ - https://github.com/lyft/cartography/issues/... -### Proof that this works -> We can merge your change in faster if we see that it works. For example, if making a change to the graph, include a -> screenshot showing what the graph looked like before and after your changes. You can also include console log traces -> showing what happened before and after your changes. - - - ### Checklist -- [ ] Update/add unit or integration tests +Provide proof that this works (this makes reviews move faster). Please perform one or more of the following: +- [ ] Update/add unit or integration tests. +- [ ] Include a screenshot showing what the graph looked like before and after your changes. +- [ ] Include console log trace showing what happened before and after your changes. + +If you are changing a node or relationship: +- [ ] Update the [schema](https://github.com/lyft/cartography/tree/master/docs/root/modules) and [readme](https://github.com/lyft/cartography/blob/master/docs/schema/README.md). -If you are modifying or implementing an intel module: -- [ ] Update the [schema](https://github.com/lyft/cartography/tree/master/docs/root/modules) and [readme](https://github.com/lyft/cartography/blob/master/docs/schema/README.md) -- [ ] Use the NodeSchema [data model](https://lyft.github.io/cartography/dev/writing-intel-modules.html#defining-a-node) +If you are implementing a new intel module: +- [ ] Use the NodeSchema [data model](https://lyft.github.io/cartography/dev/writing-intel-modules.html#defining-a-node).