Skip to content

Commit

Permalink
Create pull_request_template.md (#1157)
Browse files Browse the repository at this point in the history
Adds some guidance on how to edit/create intel modules

---------

Co-authored-by: Alex Chantavy <[email protected]>
  • Loading branch information
ramonpetgrave64 and achantavy authored Jul 20, 2024
1 parent 59db745 commit e149967
Showing 1 changed file with 25 additions and 0 deletions.
25 changes: 25 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
### Summary
> Describe your changes.


### Related issues or links
> Include links to relevant issues or other pages.
- https://github.com/lyft/cartography/issues/...


### Proof that this works
> We can merge your change in faster if we see that it works. For example, if making a change to the graph, include a
> screenshot showing what the graph looked like before and after your changes. You can also include console log traces
> showing what happened before and after your changes.


### Checklist

- [ ] Update/add unit or integration tests

If you are modifying or implementing an intel module:
- [ ] Update the [schema](https://github.com/lyft/cartography/tree/master/docs/root/modules) and [readme](https://github.com/lyft/cartography/blob/master/docs/schema/README.md)
- [ ] Use the NodeSchema [data model](https://lyft.github.io/cartography/dev/writing-intel-modules.html#defining-a-node)

0 comments on commit e149967

Please sign in to comment.