-
Notifications
You must be signed in to change notification settings - Fork 343
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Create pull_request_template.md (#1157)
Adds some guidance on how to edit/create intel modules --------- Co-authored-by: Alex Chantavy <[email protected]>
- Loading branch information
1 parent
59db745
commit e149967
Showing
1 changed file
with
25 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
### Summary | ||
> Describe your changes. | ||
|
||
|
||
### Related issues or links | ||
> Include links to relevant issues or other pages. | ||
- https://github.com/lyft/cartography/issues/... | ||
|
||
|
||
### Proof that this works | ||
> We can merge your change in faster if we see that it works. For example, if making a change to the graph, include a | ||
> screenshot showing what the graph looked like before and after your changes. You can also include console log traces | ||
> showing what happened before and after your changes. | ||
|
||
|
||
### Checklist | ||
|
||
- [ ] Update/add unit or integration tests | ||
|
||
If you are modifying or implementing an intel module: | ||
- [ ] Update the [schema](https://github.com/lyft/cartography/tree/master/docs/root/modules) and [readme](https://github.com/lyft/cartography/blob/master/docs/schema/README.md) | ||
- [ ] Use the NodeSchema [data model](https://lyft.github.io/cartography/dev/writing-intel-modules.html#defining-a-node) |