[DRAFT] Sync AWS accounts in parallel #1138
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alowde-ps
reviewed
Apr 13, 2023
| common_job_parameters, | ||
| aws_requested_syncs, | ||
| aws_best_effort_mode, | ||
| ).result() |
There was a problem hiding this comment.
I believe this will wait for each execution in turn (consecutive execution) as the call to the result() method of the Future returned by executor.submit will wait for the future to complete.
To get concurrent execution I believe you would want to submit the sync functions in a loop as is done here, collect the returned Future objects in a list and then call concurrent.futures.wait to wait for all of the syncs to be complete (or iterate over concurrent.futures.as_completed if you want to report sync statuses as they complete).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1136.