Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to pyproject.toml based build #1300

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

chandanchowdhury
Copy link
Collaborator

@chandanchowdhury chandanchowdhury commented Apr 27, 2024

As mentioned in #1016 setup.py based builds are being deprecated in favor of pyproject.toml based builds.

Important notes:

  • The build detects the package version dynamically using Git commit and tags, so had to remove .git from .dockerignore for the Python package build to succeed during Docker build.
  • However, the Docker build using Docker.multistage is multi-stage. The builder stage builds the Python package from source code. The next runner stage installs the package built in builder stage.
  • Changed .github/workflows/test_suite.yml to use the new Dockerfile.multistage. Need to update publish-to-ghcr.yml when we are satisfied with the multi-stage Docker build.
  • Added Pipfile and Pipfile.lock in case someone wants to start using pipenv or we ourselves do so in future to keep our development environment clean.

@chandanchowdhury chandanchowdhury marked this pull request as ready for review April 27, 2024 20:56
@chandanchowdhury
Copy link
Collaborator Author

Review request

@achantavy

.dockerignore Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants