-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to pyproject.toml based build #1300
Open
chandanchowdhury
wants to merge
24
commits into
cartography-cncf:master
Choose a base branch
from
chandanchowdhury:pyproject
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Switch to pyproject.toml based build #1300
chandanchowdhury
wants to merge
24
commits into
cartography-cncf:master
from
chandanchowdhury:pyproject
+2,684
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #1016
setup.py
based builds are being deprecated in favor ofpyproject.toml
based builds.Important notes:
.git
from.dockerignore
for the Python package build to succeed during Docker build.Docker.multistage
is multi-stage. Thebuilder
stage builds the Python package from source code. The nextrunner
stage installs the package built inbuilder
stage..github/workflows/test_suite.yml
to use the newDockerfile.multistage
. Need to updatepublish-to-ghcr.yml
when we are satisfied with the multi-stage Docker build.Pipfile
andPipfile.lock
in case someone wants to start usingpipenv
or we ourselves do so in future to keep our development environment clean.