From fe02cce3f57effc9e8031d67d520b97ff1d51322 Mon Sep 17 00:00:00 2001 From: Roier Date: Wed, 12 Jul 2023 12:10:13 -0600 Subject: [PATCH 1/3] fix-drawer: adding default icon on drawer --- frontend/packages/core/src/AppLayout/stories/drawer.stories.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/frontend/packages/core/src/AppLayout/stories/drawer.stories.tsx b/frontend/packages/core/src/AppLayout/stories/drawer.stories.tsx index a531213902..0a6da55ae5 100644 --- a/frontend/packages/core/src/AppLayout/stories/drawer.stories.tsx +++ b/frontend/packages/core/src/AppLayout/stories/drawer.stories.tsx @@ -27,6 +27,7 @@ export default { displayName: "EC2", group: "AWS", path: "ec2", + icon: { path: "" }, routes: [ { component: () => null, From 5640ce5292584847e67b808e99d47b7471de9476 Mon Sep 17 00:00:00 2001 From: Roier Date: Thu, 13 Jul 2023 15:24:53 -0600 Subject: [PATCH 2/3] fix-drawer: fixing tabs as well, fill array instead of empty --- .../packages/core/src/stories/tabs.stories.tsx | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/frontend/packages/core/src/stories/tabs.stories.tsx b/frontend/packages/core/src/stories/tabs.stories.tsx index b231427f70..5a87f51278 100644 --- a/frontend/packages/core/src/stories/tabs.stories.tsx +++ b/frontend/packages/core/src/stories/tabs.stories.tsx @@ -14,12 +14,14 @@ export default { const Template = ({ tabCount, value, variant }: TabsProps & { tabCount: number }) => ( - {[...Array(tabCount)].map((_, index: number) => ( - // eslint-disable-next-line react/no-array-index-key - -
Tab{index + 1} Content
-
- ))} + {Array(tabCount) + .fill(null) + .map((_, index: number) => ( + // eslint-disable-next-line react/no-array-index-key + +
Tab{index + 1} Content
+
+ ))}
); From 6ed4c9acf47ce2670895d38d19ba5c27c4abdda7 Mon Sep 17 00:00:00 2001 From: Roier Date: Thu, 13 Jul 2023 16:35:09 -0600 Subject: [PATCH 3/3] fix-drawer: Adding stepper and table fix --- .../core/src/Table/stories/table.stories.tsx | 6 ++--- .../core/src/stories/stepper.stories.tsx | 26 +++++++++++-------- 2 files changed, 18 insertions(+), 14 deletions(-) diff --git a/frontend/packages/core/src/Table/stories/table.stories.tsx b/frontend/packages/core/src/Table/stories/table.stories.tsx index d2eaf197f2..ba8f22d92d 100644 --- a/frontend/packages/core/src/Table/stories/table.stories.tsx +++ b/frontend/packages/core/src/Table/stories/table.stories.tsx @@ -20,10 +20,10 @@ export default { const Template = ({ row, ...props }: TableProps & { row: React.ReactElement }) => (
- { + {Array(10) + .fill(null) // eslint-disable-next-line react/no-array-index-key - [...Array(10)].map((_, index: number) => React.cloneElement(row, { key: index })) - } + .map((_, index: number) => React.cloneElement(row, { key: index }))}
); diff --git a/frontend/packages/core/src/stories/stepper.stories.tsx b/frontend/packages/core/src/stories/stepper.stories.tsx index 9110273a3f..7a47a3d43d 100644 --- a/frontend/packages/core/src/stories/stepper.stories.tsx +++ b/frontend/packages/core/src/stories/stepper.stories.tsx @@ -33,10 +33,12 @@ const PrimaryTemplate = ({ stepCount, activeStep }: StepperProps & { stepCount: return ( <> - {[...Array(stepCount)].map((_, index: number) => ( - // eslint-disable-next-line react/no-array-index-key - - ))} + {Array(stepCount) + .fill(null) + .map((_, index: number) => ( + // eslint-disable-next-line react/no-array-index-key + + ))}
Step{curStep + 1} content @@ -73,13 +75,15 @@ const FailureTemplate = ({ failedStep = 2, activeStep }: StepperProps & { failed return ( <> - {[...Array(stepCount)].map((_, index: number) => ( - - ))} + {Array(stepCount) + .fill(null) + .map((_, index: number) => ( + + ))}
Step{curStep + 1} content