You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Often for branding, you want qr codes in different set of colors. By allowing multiple configs in the json, one can automatically export the same qr codes for different color sets. This is super useful.
To make this feature work properly with all the existing features, we need some changes to the config.
it needs to support single AND multiple props entries
it needs to support single AND multiple data entries (in order to be compatible with the current batch feature)}
In order to support this i propose the following changes to the props. This is up for debate of course and id love to dicuss it in the comments 👍:
The new parameters are related to issues #71#70 and you could do this in a separate pr of course
and then the config json will look as follows:
{
// this will allow for both single and batches"qr_code_data": ["url1", "url2","..."],
"props": [
// first config
{
"image": "imageurl_or_data",
"...": "other props"
},
// second config
{
"...":"...",
}
// etc
]
}
The text was updated successfully, but these errors were encountered:
then i realized these parameters are meant specifically for filenames based on the issues you have referenced.
In that case, i think it's better to name them
filenamePrefix: string;
filenameSuffix: string;
I don't think there's a need for date_prefix, date_suffix (which btw should be camelcase for JS projects). These can be set within filenamePrefix / filenameSuffix accordingly by the frontend.
Next, I don't quite understand the rationale of why we should separate out the data field into an array qr_code_data, and have the rest of the configs be placed within an array props.
I prefer if we kept the current config json format so that we will not break backward compability for current users who already saved their JSON config, and wants to import their JSON config.
JSON can be both the usual {} object or an array []. So then we will accept both {data, ...props} config or the new array format of [{data1, ...props1}, {data2,...props2}].
Often for branding, you want qr codes in different set of colors. By allowing multiple configs in the json, one can automatically export the same qr codes for different color sets. This is super useful.
To make this feature work properly with all the existing features, we need some changes to the config.
props
entriesIn order to support this i propose the following changes to the props. This is up for debate of course and id love to dicuss it in the comments 👍:
The new parameters are related to issues #71 #70 and you could do this in a separate pr of course
and then the config json will look as follows:
The text was updated successfully, but these errors were encountered: