Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qr code should be viewable at all times #9

Open
lyqht opened this issue Aug 6, 2023 · 1 comment
Open

Qr code should be viewable at all times #9

lyqht opened this issue Aug 6, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@lyqht
Copy link
Owner

lyqht commented Aug 6, 2023

currently

On desktop, if u have to scroll down to play w the settings at the bottom, you will have to scroll back up to see the preview.

On mobile, it's intentionally designed so the user see the settings first before seeing the QR. However this leads to a similar problem of having to scroll down in order to see the QR

possible solution

For desktop, just make qr code sticky/fixed.

For mobile, there are a few possible ways to do this:

  1. Show a small version of the qr code at the side while user is at settings, then when they reach the actual qr code section, the small qr code should zoom/transform into the main qr code OR
  2. Use a bottom sheet (preferred)
@lyqht lyqht added the enhancement New feature or request label Aug 6, 2023
@lyqht
Copy link
Owner Author

lyqht commented Aug 8, 2023

Fixed this issue for Desktop in 40f03e6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant