Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error messages instead of parse errors #8

Open
m-yac opened this issue Aug 21, 2021 · 1 comment
Open

Better error messages instead of parse errors #8

m-yac opened this issue Aug 21, 2021 · 1 comment
Labels
later This issue will not be fixed in the near future microtonal-utils This issue involves making a change to microtonal-utils

Comments

@m-yac
Copy link
Owner

m-yac commented Aug 21, 2021

In general, the parser should be more lenient, so that the user sees less parse errors and instead more human-readable errors and/or more "Did you mean" messages. For example:

  1. Hyphenation should be allowed anywhere in a verbose color prefix, with "Did you mean" text when it's non canonical. See: feature request: use "co-" prefix to avoid huge degrees in color names microtonal-utils#5 (comment)
  2. Trying to combine additive and multiplicative expressions shouldn't give a parse error, it should give a more helpful and readable error. Same with trying to add/multiply/etc. two notes.

This would involve significantly rewriting the parser to make it more lenient, and replacing eval.js with something more robust to enable it to inspect the output of the parser in more detail.

@m-yac
Copy link
Owner Author

m-yac commented Aug 30, 2021

(1) is done in m-yac/microtonal-utils@e9ffc30 and 702dc15.

@m-yac m-yac added later This issue will not be fixed in the near future microtonal-utils This issue involves making a change to microtonal-utils labels Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
later This issue will not be fixed in the near future microtonal-utils This issue involves making a change to microtonal-utils
Projects
None yet
Development

No branches or pull requests

1 participant