Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the AppDomain and Remoting code #307

Open
ivanz opened this issue Jul 30, 2016 · 2 comments
Open

Remove the AppDomain and Remoting code #307

ivanz opened this issue Jul 30, 2016 · 2 comments

Comments

@ivanz
Copy link
Contributor

ivanz commented Jul 30, 2016

In potential scenario where .NET CLI and .NET Core picks up and takes over the .NET world we should think about whether we want to keep (and maintain) the AppDomain test runner interface in Machine.Specifications. An AppDomain runner wrapper around the [reflection-based Test Controller] can be added to the test runner util

This is open to discussion and is likely not going to happen any time soon.

@ivanz ivanz added this to the 1.0.0 milestone Jul 30, 2016
@fschmied
Copy link

@ivanz How will the test runner support project-specific app.config files without AppDomain and Remoting code?

@ivanz
Copy link
Contributor Author

ivanz commented Aug 22, 2016

@fschmied Good question.

The current use of remoting in the Machine.Specifications code is for IPC and to enable a version-independent interface. Given that we now have a reflection-based test controller protocol (similarly to nunit and xunit) - there is no reason to have dependency on remoting in the core of MSpec. That doesn't mean that the test runner utility can't continue to create and run tests in AppDomains (it does this already) - just not use it for the version-independency.

Not having a remoting (appdomains, binary serialization, etc) dependency in the core of MSpec makes the core much more portable.

@robertcoltheart robertcoltheart removed this from the 1.0.0 milestone Jan 10, 2019
@robertcoltheart robertcoltheart added this to the 2.0.0 milestone Jun 12, 2019
@robertcoltheart robertcoltheart modified the milestones: 2.0.0, 3.0.0 Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants