Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestCaseFilter support #327

Closed
ivanz opened this issue Mar 17, 2017 · 6 comments
Closed

TestCaseFilter support #327

ivanz opened this issue Mar 17, 2017 · 6 comments

Comments

@ivanz
Copy link
Contributor

ivanz commented Mar 17, 2017

Migrated from vstest adapter repo

it is whatever vstest supports, so test category, class name etc.

/TestCaseFilter:"TestCategory=Nightly|FullyQualifiedName=Namespace.ClassName.MethodName"

@einari
Copy link
Contributor

einari commented Mar 18, 2017

We should also remember to get a pull request in for the documentation for VSTest when it is implemented.

I would be happy to jump in on this particular feature - as I really need it now for VSCode :)

One type of filter I would like to add would be to support having a file and a line number passed in. That way I can get VSCode information directly sent in as filter (variables in VSCode)

@einari einari self-assigned this Mar 19, 2017
@ivanz
Copy link
Contributor Author

ivanz commented Mar 22, 2017

I am wondering if we can "upgrade" the existing RunOptions in MSpec to support those extra scenarios in a backwards compatible way such that if an older Machine.Specification version is used - it still works, but the filters are not applied.

The main reason I added the TestController in MSpec was to be able to use simple reflection for running tests and I didn't actually intend it to be a filtering mechanism itself, but as it happened at the time it was a convenient way to use it for that. and it already takes in a string xml of runOptions in one of its constructors: https://github.com/machine/machine.specifications/blob/master/Source/Machine.Specifications/Controller/Controller.cs#L27

end of brain dump :)

@MattRyan
Copy link

MattRyan commented Aug 8, 2018

I have created pull request #352 to expand RunOptions to include a context and specification filters.

@mikeblakeuk
Copy link
Contributor

@einari / @MattRyan Can you try the latest version (beta) of the adapter please. thanks

@robertcoltheart
Copy link
Member

Please let me know once you're happy and I can close this issue.

@robertcoltheart robertcoltheart removed this from the 2.0.0 milestone Apr 28, 2020
@mikeblakeuk
Copy link
Contributor

mikeblakeuk commented Jan 14, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants